Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update t0 label const name to disambiguate from high value #1196

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Mar 5, 2025

Description

Two different constants are created for disambiguation purposes: TIER_ZERO_LABEL and HIGH_VALUE_LABEL.

Motivation and Context

This PR addresses: BED-5524

There was a constant in the BHE repository that is also called TIER_ZERO_LABEL which has a different string value assigned to it. The constant name update helps with disambiguation and makes it clear that these constants do not have the same value.

How Has This Been Tested?

The bug is upstream. The project builds as the updated constant name is updated where it was used.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@urangel urangel added bug Something isn't working user interface A pull request containing changes affecting the UI code. release blocker Must be completed before next release labels Mar 5, 2025
@urangel urangel self-assigned this Mar 5, 2025
Copy link
Contributor

@mvlipka mvlipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for moving this to the shared UI

@urangel urangel merged commit 42e580a into stage/v7.1.0 Mar 5, 2025
6 checks passed
@urangel urangel deleted the BED-5524 branch March 5, 2025 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release blocker Must be completed before next release user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants